Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor WorkRatioChart and ActiveEmployeeCard components-Exhausted B… #403

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

Tinashe-Austin
Copy link
Contributor

…ut we keep pushing ah

  • Replaced Spinner component with Skeleton component for loading state in WorkRatioChart component.
  • Replaced Spinner component with Skeleton component for loading state in ActiveEmployeeCard component.

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #401

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

…ut we keep pushing ah

- Replaced Spinner component with Skeleton component for loading state in WorkRatioChart component.
- Replaced Spinner component with Skeleton component for loading state in ActiveEmployeeCard component.
@Tinashe-Austin Tinashe-Austin added type: chore Just a cleanup or minor update type: fix Introduces a fix for a previous issue For: frontend This is mainly related to frontend UI code priority: medium This does/did not need to be addressed soon but should have plans in place to be addressed effort: 5 This may require/required hours of work platform: web/desktop This is related to web/desktop platforms For: integration This is for work involving integration with the backend/model API labels Sep 26, 2024
@Tinashe-Austin Tinashe-Austin self-assigned this Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.78%. Comparing base (42d9956) to head (e678f92).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #403   +/-   ##
========================================
  Coverage    42.78%   42.78%           
========================================
  Files           18       18           
  Lines          416      416           
========================================
  Hits           178      178           
  Misses         238      238           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tinashe-Austin Tinashe-Austin merged commit 11d8e2f into develop Sep 26, 2024
7 checks passed
@waveyboym waveyboym deleted the fix/web/general-polishing-up branch September 28, 2024 16:15
@waveyboym waveyboym restored the fix/web/general-polishing-up branch September 28, 2024 16:15
@waveyboym waveyboym deleted the fix/web/general-polishing-up branch September 28, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: 5 This may require/required hours of work For: frontend This is mainly related to frontend UI code For: integration This is for work involving integration with the backend/model API platform: web/desktop This is related to web/desktop platforms priority: medium This does/did not need to be addressed soon but should have plans in place to be addressed type: chore Just a cleanup or minor update type: fix Introduces a fix for a previous issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK]Fixes for web
1 participant